Point leftover Invite to this Bot copy at Sharing → Copy invite link - #515

Self-review: PASS
Tip SHA: 9fdb694
Ran:

• ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify (pass)
• reviewed diff at tip vs owner design rules
  Not run:
• live Mac instances / production Bot Social

Self-review: PASS
Tip SHA: bf85bfd
Ran:

• git merge origin/main (eb91742, after Remind about approvals waiting 15 min, switch each notification kind, one notification per chat #492 and Social: neutral 'You already have …' on a re-accepted invite; clearer Remove confirm #503) into the branch, no rebase or force-push; merged the updated Polish invites and friend chats: friend Bot placeholder, one invite control, Add friend auto-close, Sharing hint #504 branch (347f18e, which already has main eb91742) into this branch so the stack stays consistent; only conflict was the generated patches/ds-bot/0008-client-bundle.patch
• generated files regenerated, not hand-merged: took main's patches/ds-bot, then (cd core && npm run build), node scripts/ds-bot-patches.mjs generate, then check: ok (10 patches apply cleanly; core/ = ds-bot/ + patches)
• ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify (core lint + arch-docs, plugin lint, build-client --check, ds-bot-patches check, all suites): pass, 0 failures (core 1100, social 312, tree 80, timeline 92, .github scripts 93, interop 37, live-e2e 16)
• CI on this tip: all checks pass (tests-ok, Node 24 · DSH 0.2.0-rc.2, plugins social/timeline/tree, package, risk tier, reviewed tip); mergeable MERGEABLE, mergeStateStatus CLEAN
• re-read the diff against main at this tip: changelog.d fragment kept, no CHANGELOG.md or ds-bot/ edits, owner design rules kept (approvals only via UI buttons, English UI, no separate Friends' Bots section, no turn limit or Extend in friend chats, connector tokens only at /mcp)
  Not run:
• live Mac instances / production Bot Social

Self-review (review-pr, Birfy reviewer agent, 2026-10-20 20:41 Asia/Shanghai): PASS (merge-main conflict fix; no feature change)

Tip SHA: cb7cb2f
Ran:

• git merge origin/main twice into the branch, no rebase or force-push: first b6e89d2 (with Polish invites and friend chats: friend Bot placeholder, one invite control, Add friend auto-close, Sharing hint #504 now on main, so this PR is no longer stacked and its diff vs main is just the Host/core messages and zh strings still say 'Bot settings → Invite to this Bot' after #504 #506 copy change), then cf61952 (after Name a friend's Bot one way and approval cards by the receiving person #502, which landed while this was being checked) → pass. The first merge's only conflict was the generated patches/ds-bot/0008-client-bundle.patch. The second merge was clean. No hand-merged real sources
• generated files regenerated, not hand-merged, after each merge: git checkout origin/main -- patches/ds-bot, (cd core && npm run build), node scripts/ds-bot-patches.mjs generate, check → pass (10 patches apply cleanly; core/ = ds-bot/ + patches)
• ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify (core lint + arch-docs OK with 24 changed files, plugin lint, build-client --check, ds-bot-patches check, all suites) → pass, 0 failures (core 1114, social 313, tree 83, timeline 93, .github scripts 93, interop 37, live-e2e 16)
• smoke (PR touches core/src/host/ copy in hooks.js, reach.js, room-membership.js): CONTEXT_WINDOW=100000 CHECK_RATIO=0.45 dev/bench.sh smoke515 3297 8997 reset && node dev/smoke.mjs smoke515 3297 against DSH 0.2.0-rc.2, on the cf61952 merge → pass, all 42 steps; bench stopped afterwards
• CI on this tip → all checks pass (tests-ok, ubuntu-latest · Node 24 · DSH 0.2.0-rc.2, plugins social/timeline/tree, package, risk tier, reviewed tip); MERGEABLE / CLEAN
• re-read the diff against main at this tip: 24 files, every change replaces leftover "Invite to this Bot" copy with Sharing → Copy invite link. One changelog.d fragment (506-invite-copy-leftovers.fixed.md), no CHANGELOG.md or ds-bot/ edits, no node_modules links committed
  Not run:
• live Mac instances / DSH Desktop / real-model live-e2e (no key; mock model only)
• production Bot Social (not in scope)
  Verdict: PASS

Findings: none to act on. This review does not authorize a merge: risk:T3 still needs the maintainer's approval (the owner queues it).

Verifier report (review-pr), PR #515

Verdict: PASS at ae902933acaf8bc2ec68c55a044dec654838994d. Self-review by the owner's reviewer agent (Birfy, selfReview). Rules loaded from origin/main: AGENTS.md, LESSONS.md, docs/code-standards.md, review-pr.

Why it left the merge queue: run 39433298601 failed arch-docs. The PR changes owned files (core-client, core-host, plugin-runtime, tree) and updates only social.md / team.md; on the branch the check passed because commit 6e7e9e6 carries a Docs-not-needed: line, but the queue squashes the PR title and body, and the body had none. Reproduced locally on a simulated squash (FAIL without the line, OK with it).

Changes: plain merges of origin/main 17af764 (#544) and 93dc3c9 (#551), no conflicts, generate gave no further change, topics.json equals main's; the merge commit and the PR body now carry Docs-not-needed: (copy-only string and comment updates; no subsystem doc names the old control). Diff vs main re-read: only the "Invite to this Bot" → "Sharing → Copy invite link" copy, its zh string, comments and one test assertion. Also merged 6824c61 (#547) locally (not pushed): clean, verify green.

Tip SHA: ae902933acaf8bc2ec68c55a044dec654838994d
Ran:
  - ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify (Node 24.21.0) → pass (core 1129/0, social 313/0, tree 83/0, timeline 93/0, scripts 93/0, interop 37/0, live-e2e 16/0; arch-docs OK 24 files)
  - node scripts/ds-bot-patches.mjs check → pass
  - arch-docs on a simulated squash onto origin/main: without trailer → fail, with trailer → pass
  - dev/bench.sh + node dev/smoke.mjs (DSH 0.2.0-rc.2, mock model) → pass, 42/42 steps
  - local merge with origin/main 6824c61 (#547) + verify → pass
  - GitHub CI at tip (tests-ok and all jobs) → pass
Not run:
  - Desktop app manual check — copy-only change
  - real-model run — mock model only
Verdict: PASS

No actionable findings. This report is not merge authority.

Re-queued: originally owner-queued; it left the queue only because the squash body lacked the Docs-not-needed line (arch-docs). No change to the reviewed copy.